Optimize updatePath function with tbb
#260
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| std::execution::par_unseq, | ||
| m_graph.nodeSet().begin(), | ||
| m_graph.nodeSet().end(), | ||
| [this, &shortestDistances, &destinationID](auto const& it) -> void { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule Note
| minDistance) < 1.}; // 1 meter tolerance between shortest paths | ||
| if (nextNodeId == destinationID) { | ||
| if (bIsMinDistance) { | ||
| if (std::abs(m_graph.street(nodeId * dimension + nextNodeId)->length() - |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
| } else if ((nextNodeId != destinationID)) { | ||
| Logger::warning(std::format( | ||
| "No path found from node {} to node {}", nextNodeId, destinationID)); | ||
| auto const distance{shortestDistances[nextNodeId]}; |
Check warning
Code scanning / Cppcheck (reported by Codacy)
Local variable 'distance' shadows outer function Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 90.48% 90.56% +0.08%
==========================================
Files 37 37
Lines 4898 4898
Branches 457 452 -5
==========================================
+ Hits 4432 4436 +4
+ Misses 466 462 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| minDistance) < 1.}; // 1 meter tolerance between shortest paths | ||
| if (nextNodeId == destinationID) { | ||
| if (bIsMinDistance) { | ||
| if (std::abs(m_graph.street(nodeId * dimension + nextNodeId)->length() - |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
| } | ||
| auto result{m_graph.shortestPath(nodeId, destinationID)}; | ||
| if (!result.has_value()) { | ||
| // save the minimum distance between i and the destination |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 14.4 rule Note
Grufoony
changed the title
updatePath functionupdatePath function with tbb
Before: Average execution time : 416
After: Average execution time : 78